feat: Marker-Cleanup zur Vermeidung von Memory Leaks implementiert
- cleanupMarkers() Utility in /utils/common/cleanupMarkers.js erstellt - Marker-Cleanup in MapComponent.js vor createAndSetDevices() integriert - createAndSetDevices.js von Cleanup-Verantwortung befreit (reine Erzeugung) - setupPOIs.js erweitert um cleanupMarkers() vor Layer-Neuerstellung - poiUtils.js und markerUtils.js angepasst: cleanupMarkers() ersetzt .remove() - Memory Leaks durch verwaiste Tooltips, Events und Marker behoben - Grundlage für wiederverwendbare Marker-Cleanup-Logik für POIs, Geräte, Linien geschaffen
This commit is contained in:
@@ -5,8 +5,9 @@ import circleIcon from "../components/CircleIcon";
|
||||
import { store } from "../redux/store";
|
||||
import { updatePolylineCoordinatesThunk } from "../redux/thunks/database/polylines/updatePolylineCoordinatesThunk";
|
||||
import { redrawPolyline } from "./mapUtils";
|
||||
import { cleanupMarkers } from "@/utils/common/cleanupMarkers";
|
||||
|
||||
const savePolylineRedux = (lineData) => {
|
||||
const savePolylineRedux = lineData => {
|
||||
return store
|
||||
.dispatch(
|
||||
updatePolylineCoordinatesThunk({
|
||||
@@ -16,7 +17,7 @@ const savePolylineRedux = (lineData) => {
|
||||
})
|
||||
)
|
||||
.unwrap()
|
||||
.catch((error) => {
|
||||
.catch(error => {
|
||||
console.error("Fehler beim Speichern der Linienkoordinaten:", error.message);
|
||||
});
|
||||
};
|
||||
@@ -44,18 +45,27 @@ export const insertNewMarker = (closestPoints, newPoint, lineData, map) => {
|
||||
};
|
||||
|
||||
export const removeMarker = (marker, lineData, currentZoom, currentCenter) => {
|
||||
const index = lineData.coordinates.findIndex((coord) => L.latLng(coord[0], coord[1]).equals(marker.getLatLng()));
|
||||
const index = lineData.coordinates.findIndex(coord =>
|
||||
L.latLng(coord[0], coord[1]).equals(marker.getLatLng())
|
||||
);
|
||||
|
||||
if (index !== -1) {
|
||||
lineData.coordinates.splice(index, 1);
|
||||
redrawPolyline(lineData);
|
||||
marker.remove();
|
||||
cleanupMarkers([marker]);
|
||||
savePolylineRedux(lineData); // ✅ Wiederverwendung
|
||||
window.location.reload();
|
||||
}
|
||||
};
|
||||
|
||||
export const handleEditPoi = (marker, userRights, setCurrentPoiData, setShowPoiUpdateModal, fetchPoiData, toast) => {
|
||||
export const handleEditPoi = (
|
||||
marker,
|
||||
userRights,
|
||||
setCurrentPoiData,
|
||||
setShowPoiUpdateModal,
|
||||
fetchPoiData,
|
||||
toast
|
||||
) => {
|
||||
if (!Array.isArray(userRights)) {
|
||||
toast.error("Benutzerrechte sind ungültig.", {
|
||||
position: "top-center",
|
||||
@@ -64,7 +74,7 @@ export const handleEditPoi = (marker, userRights, setCurrentPoiData, setShowPoiU
|
||||
return;
|
||||
}
|
||||
|
||||
if (!userRights.some((r) => r.IdRight === 56)) {
|
||||
if (!userRights.some(r => r.IdRight === 56)) {
|
||||
toast.error("Benutzer hat keine Berechtigung zum Bearbeiten.", {
|
||||
position: "top-center",
|
||||
autoClose: 5000,
|
||||
|
||||
Reference in New Issue
Block a user